Club career

Taha started his youth career in Zamalek in 1925. He was 18 when played his first game for the first team in the 1928–29 season, he won with Zamalek in his first season the 1928–29 Cairo League title.

In Zamalek, Taha played in the prime of his career with Egyptian veteran players such as Mohamed Latif, Hussein Hegazi, El-Sayed Abaza and Ismail Raafat. He scored his first goal in the Cairo derby in the 1929–30 season. In 1931, Taha made a surprise move to arch rival Al Ahly, he played with them for two seasons until 1933, then he moved back to Zamalek and played until the end of his career.^[4] Taha scored over 100 goals with Zamalek, he won with Zamalek seven Cairo League titles, five Egypt Cup titles and the King Fouad Cup for one time.

He was Zamalek's captain in the early 1940s, he was the one who lifted the 1944 Egypt Cup trophy, this cup's final was a historical match with Zamalek's highest victory over Al Ahly with a score of 6–0, which is the largest score in the history of the Egypt Cup final matches and in the history of the Cairo derby. He was a prolific goal scorer and he is the second all-time top scorer of the Cairo derby with 17 goals and Zamalek's all-time top scorer of the derby with 12 goals. He changed his position and played as a defender in the last three seasons of his career. Taha retired after winning the 1944–45 Cairo League.^[5]

International career

Taha played his first international game with the Egypt national football team in 1929, he played for his country until 1940, he was a part of the team that played in the 1934 World Cup, and played Egypt's game in the group stage, he was also a part of the team that played in that 1936 Olympics in Berlin.^[6]